[Intel-gfx] Patch for testing irq spinning

[Keith Packard]

On Wed, 2008-12-03 at 23:52 +0100, Pierre Willenbrock wrote:
> Keith Packard schrieb:
> > Here's a patch which switches from using pipestat to using iir to see
> > vblank interrupts. I'm wondering what this will do on machines where
> > people are seeing interrupts get stuck on (and then disabled by the
> > kernel).
> > 
> > If you're having any IRQ issues, please give this a try and let me know
> > what you discover.
> 
> With this patch, my machine behaves essentially the same as without.
> After some time the irq gets stuck. Adding the 1000 loop delay at the
> end of the for loop(see bug 18609) helped, meaning i am still waiting
> for the irq to get stuck.

What chip is this? Are you on MSI? What happens when you remove the
looping behaviour from the IRQ handler?

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 6166b15..91ca991 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -254,6 +254,7 @@ irqreturn_t i915_driver_irq_handler(DRM_IRQ_ARGS)
 		 * stray interrupts.
 		 */
 		iir = new_iir;
+		break;
 	}
 
 	return ret;

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081203/058d5aaf/attachment.sig>