[Intel-gfx] [PATCH] drm/i915: Don't detach physical objects of cursor bo at cursor off

Eric Anholt eric at anholt.net
Wed Dec 16 19:48:16 CET 2009


On Tue, 22 Sep 2009 11:26:27 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Tue, 22 Sep 2009 11:10:47 +0800
> Li Peng <peng.li at linux.intel.com> wrote:
> 
> > The cache line flush in i915_gem_detach_phys_object() is big overhead
> > if userspace app keep updating cursor bo and turn it on and off.
> > We can keep using the physical objects attached at first time and
> > don't detach them at cursor turning off. It will reduce the overhead.
> > 
> > Signed-off-by: Li Peng <peng.li at intel.com>
> 
> I recently pushed a change to the 2D driver to avoid the on/off calls;
> it might help avoid the overhead you're fixing here.
> 
> commit b8c5c996e888485c3a16d645c8490592534a7882
> Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> Date:   Tue Sep 15 19:45:47 2009 -0700
> 
>     Eliminate cursor flicker
> 
> Jesse

So, is this still an issue?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091216/536c0b9c/attachment.sig>


More information about the Intel-gfx mailing list