[Intel-gfx] [PATCH] drm/i915: Don't detach physical objects of cursor bo at cursor off

[Li Peng]

On Tue, 2009-09-22 at 11:26 -0700, Jesse Barnes wrote:
> On Tue, 22 Sep 2009 11:10:47 +0800
> Li Peng <peng.li at linux.intel.com> wrote:
> 
> > The cache line flush in i915_gem_detach_phys_object() is big overhead
> > if userspace app keep updating cursor bo and turn it on and off.
> > We can keep using the physical objects attached at first time and
> > don't detach them at cursor turning off. It will reduce the overhead.
> > 
> > Signed-off-by: Li Peng <peng.li at intel.com>
> 
> I recently pushed a change to the 2D driver to avoid the on/off calls;
> it might help avoid the overhead you're fixing here.
> 
> commit b8c5c996e888485c3a16d645c8490592534a7882
> Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> Date:   Tue Sep 15 19:45:47 2009 -0700
> 
>     Eliminate cursor flicker
> 
> Jesse

Eric:

Jesse's patch already fixed this issue.  So my patch won't be needed any
more.
Sorry for the late reply.

Peng