[Intel-gfx] [PATCH] Correct alignment for framebuffer

Eric Anholt eric at anholt.net
Tue Feb 3 17:46:42 CET 2009


On Tue, 2009-02-03 at 16:29 +0000, Chris Wilson wrote:
> Hello all,
> 
> intel_pipe_set_base() sets an invalid alignment for I915_TILING_X on an
> i915, triggering the warning "i915_write_fence_reg: object 0x00a00000
> not 1M or size (0x400000) aligned".
> 
> The attached patch uses i915_gem_get_gtt_alignment() to compute the
> correct alignment for a fenced object.

The pinning code is supposed to pin you to the maximum of the requested
alignment (due to whatever constraints of the unit that you're pinning
the object for) and the fence covering the object, if any.  It looks
like instead it only pins you to fence alignment if you didn't request
any alignment at all.  Just pass 0.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090203/a911548d/attachment.sig>


More information about the Intel-gfx mailing list