[Intel-gfx] [PATCH] Correct alignment for framebuffer

[Jesse Barnes]

On Tuesday, February 3, 2009 8:46 am Eric Anholt wrote:
> On Tue, 2009-02-03 at 16:29 +0000, Chris Wilson wrote:
> > Hello all,
> >
> > intel_pipe_set_base() sets an invalid alignment for I915_TILING_X on an
> > i915, triggering the warning "i915_write_fence_reg: object 0x00a00000
> > not 1M or size (0x400000) aligned".
> >
> > The attached patch uses i915_gem_get_gtt_alignment() to compute the
> > correct alignment for a fenced object.
>
> The pinning code is supposed to pin you to the maximum of the requested
> alignment (due to whatever constraints of the unit that you're pinning
> the object for) and the fence covering the object, if any.  It looks
> like instead it only pins you to fence alignment if you didn't request
> any alignment at all.  Just pass 0.

Oh right, we should probably fix that though... maybe by returning -EINVAL 
when a bad (or nonzero) alignment is passed.

-- 
Jesse Barnes, Intel Open Source Technology Center