[Intel-gfx] [PATCH] i830_driver.c:detect and initialize SDVOB and SDVOC at the same time.

Eric Anholt eric at anholt.net
Tue Feb 3 18:01:49 CET 2009


On Tue, 2009-02-03 at 16:10 +0800, Ma Ling wrote:
> hi All,
> 
> SDVO chipset has one i2c pin pare from GMCH, usually port4.
> So for sdvo detection we only need to check digital port B (bit 2) of SDVOB.
> In another word we should initialize SDVOC port at the same time when SDVOB detection is successful.
> The patch is based on our latest code, and intends to match the above logic.
> Any comments are welcome !

First, please fix your whitespace -- you reindented a block of 3-space
code to 4-space.

As of GM45, there are 2 pin pairs once again -- HDMI/DPC is on pin 3,
thus the new bit for detection, and this change would regress that.

Also, modesetting fixes need to go to the kernel first.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090203/669e4e82/attachment.sig>


More information about the Intel-gfx mailing list