[Intel-gfx] [PATCH] i830_driver.c:detect and initialize SDVOB and SDVOC at the same time.

[Fu Michael]

Eric Anholt wrote:
> On Tue, 2009-02-03 at 16:10 +0800, Ma Ling wrote:
>   
>> hi All,
>>
>> SDVO chipset has one i2c pin pare from GMCH, usually port4.
>> So for sdvo detection we only need to check digital port B (bit 2) of SDVOB.
>> In another word we should initialize SDVOC port at the same time when SDVOB detection is successful.
>> The patch is based on our latest code, and intends to match the above logic.
>> Any comments are welcome !
>>     
>
> First, please fix your whitespace -- you reindented a block of 3-space
> code to 4-space.
>
> As of GM45, there are 2 pin pairs once again -- HDMI/DPC is on pin 3,
> thus the new bit for detection, and this change would regress that.
>   
I think that's only true if the port is used as HDMI, otherwise it still 
share the same detection bit as SDVOB. Though I agree the patch need to 
be enhanced to cover that.
> Also, modesetting fixes need to go to the kernel first.
>   
disagree. should be fixed in both side. KMS is still not the first 
choice for most user yet.
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>