[Intel-gfx] [PATCH 00/13] Xv cleanup and preparatory revamp for drmmode overlay

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Vetter wrote:
> Hi all,
> 
> This patch series has two goals:
> 
> - Clean up the code Xv so I can understand it. I've mostly changed overlay
>   related code. But I've also put some of the newly introduced helpers in
>   textured video to some use. Still, only tested on a 855GM because that's
>   the only hw I have.
> - Revamp the code to prepare for drmmode overlay support. Minus
>   initialization and mode-switching, all overlay hw access goes now through
>   the three ums_overlay_* functions. My next planned step is to put the
>   functionality of these 3 functions into the kernel drm.
> 
> The complete series should work after every patch to ease regression fixing
> (as I've said, only tested on a 855GM).
> 
> Comments (esp. concerning my planned Xorg/kernel drm split) and testing
> feedback highly welcome.
> 
> Yours, Daniel
> 
> Daniel Vetter (13):
>   Xv: kill unneeded indirection
>   Xv overlay: implement GAMMA5 errata
>   Xv: kill !textured condition

I pushed these three.

>   Xv overlay: Cut 400 line function i830_display_video into smaller
>     chunks

This one was tough to review just because it creates a lot of churn.  In
the future, it might be better to do things like this as a series of
smaller patches.  It looks like the code in i830_calc_src_regs,
i830_update_dst_box_to_crtc_coords, i830_store_coeffs_in_overlay_regs,
etc. just comes from the original monster function.  It would be much
easier to review if each of these functions was added in a separate patch.

>   Xv: introduce planar memcpy helper
>   Xv: use is_planar_fourcc helper some more

I'm going to verify that this applies without the previous two.  If it
does, I'll push it as well.

>   Xv: kill hw double buffering logic

I'll leave this for someone else to review.  I'm not familiar with that
aspect.

>   Xv: kill destId in I830PutImage

Same as "Xv: use is_planar_fourcc helper some more"

>   Xv: split up I830PutImage
>   Xv: scrap overlay offscreen pixmap support
>   Xv: create xvmc_passthrough helper
>   Xv: rework overlay buffer management
>   Xv: introduce an overlay hal

I should be able to review the rest of these over the next day or so.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpL55oACgkQX1gOwKyEAw8JWwCfXqbP41xE5OD/cjZGP6W7Sv2e
DkkAnjlTHsvL5Z2EF2me/sQztatugDtQ
=musM
-----END PGP SIGNATURE-----