[Intel-gfx] [PATCH 00/13] Xv cleanup and preparatory revamp for drmmode overlay

[Daniel Vetter]

On Wed, Jul 01, 2009 at 03:47:57PM -0700, Ian Romanick wrote:
> >   Xv overlay: Cut 400 line function i830_display_video into smaller
> >     chunks
> 
> This one was tough to review just because it creates a lot of churn.  In
> the future, it might be better to do things like this as a series of
> smaller patches.  It looks like the code in i830_calc_src_regs,
> i830_update_dst_box_to_crtc_coords, i830_store_coeffs_in_overlay_regs,
> etc. just comes from the original monster function.  It would be much
> easier to review if each of these functions was added in a separate patch.

This is exactly what the patch does - unfortunately the diff is completely
unreadable because the indentation of the various blocks changed. I'll
split it up as suggested, rebase on master.

> >   Xv: introduce planar memcpy helper
Have you looked at this already? It _should_ be independant of the
previous one. And I've tested all four cases (= crtc rotations) besides
checking that the code really is the same (minus different parameters) in
all three instances.

> >   Xv: use is_planar_fourcc helper some more
> 
> I'm going to verify that this applies without the previous two.  If it
> does, I'll push it as well.

Just in case they don't, I'll repost them again.

> >   Xv: kill hw double buffering logic
> 
> I'll leave this for someone else to review.  I'm not familiar with that
> aspect.
O.k. But most likely the following patches will fail to apply.

> >   Xv: kill destId in I830PutImage
> 
> Same as "Xv: use is_planar_fourcc helper some more"
> 
> >   Xv: split up I830PutImage
This is the second monster-function split-up. I'll also split to up for
easier review.

> >   Xv: scrap overlay offscreen pixmap support
> >   Xv: create xvmc_passthrough helper
> >   Xv: rework overlay buffer management
> >   Xv: introduce an overlay hal
> 
> I should be able to review the rest of these over the next day or so.

Thanks for reviewing. When reposting, I'll also add the two patches by
Barry Scott on top of my work.

-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: 079 365 57 48