[Intel-gfx] [PATCH 2/4] DRM/I915: Add the debug info for i915 connectors/crtc by using DRM_DEBUG_KMS

[Eric Anholt]

On Thu, 2009-07-09 at 18:02 +0800, yakui.zhao at intel.com wrote:
> From: Zhao Yakui <yakui.zhao at intel.com>
> 
> Add the debug info for i915 connectors/crtc by using the DRM_DEBUG_KMS instead
> of DRM_DEBUG in KMS mode.
> 
> Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>

If each file is defining a prefix that happens to be the filename
slightly mangled, why don't we just use the filename as the prefix and
not have to specify it per debug call?  We'd get more sensible output
and less code.

I still dislike the KMS versus MODE split.  I think I'd end up looking
up what the difference was supposed to be every time I wrote a debug
call for them.  (though the fact that they're split by filename makes
copying easier)

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090713/cad06095/attachment.sig>