[Intel-gfx] [PATCH 2/4] DRM/I915: Add the debug info for i915 connectors/crtc by using DRM_DEBUG_KMS

[ykzhao]

On Tue, 2009-07-14 at 07:07 +0800, Eric Anholt wrote:
> On Thu, 2009-07-09 at 18:02 +0800, yakui.zhao at intel.com wrote:
> > From: Zhao Yakui <yakui.zhao at intel.com>
> > 
> > Add the debug info for i915 connectors/crtc by using the DRM_DEBUG_KMS instead
> > of DRM_DEBUG in KMS mode.
> > 
> > Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> 
> If each file is defining a prefix that happens to be the filename
> slightly mangled, why don't we just use the filename as the prefix and
> not have to specify it per debug call?  We'd get more sensible output
> and less code.
If the __FILE__ macro is used directly, it will be simpler. But it seems
that the full file name is printed.
Maybe it will be more flexible that we can define the prefix name. 
> 
> I still dislike the KMS versus MODE split.  I think I'd end up looking
> up what the difference was supposed to be every time I wrote a debug
> call for them.  (though the fact that they're split by filename makes
> copying easier)
The four macro definitions are provided. And they can be used in
different files. The purpose is that we can get the info we wanted by
adding the different level.
For example: 
    DRM_DEBUG_KMS can be used to add the debug info related with the
KMS.
    DRM_DEBUG_MODE can be used to add the debug info in generic drm
mode.    
If we want to get the info about how the connector/encoder is
initialized/configured, we can ignore the info related with mode. 
If the KMS/MODE is not split, we will have to get too much info related
with mode.(For example: modeline)

thanks.
   Yakui
>