[Intel-gfx] [PATCH] drm/i915: Add sanity check for LVDS timing from VBT

[Jesse Barnes]

On Fri, 10 Jul 2009 14:51:27 +0800
Zhenyu Wang <zhenyuw at linux.intel.com> wrote:

> From: Zhenyu Wang <zhenyu.z.wang at intel.com>
> 
> Some invalid LVDS timing block has been observed.
> It's better to check modeline from VBT instead of
> possible fail later.
> 
> Signed-off-by: Zhenyu Wang <zhenyu.z.wang at intel.com>
> ---

This one conflicts with Quanxian's patch.  Also, I'd like to see some
sanity checks as a drm_crtc_helper function as well (for use before
calling the actual mode_set routines).  We should be validating the
hdisp < htotal etc in generic code, and then validate our values are
divisible by 2 in the LVDS dual channel case for example in the lvds
mode setting code.

This patch is ok though too, assuming this is a fairly common issue, so
if you can get things worked out with Quanxian (and address Yakui's
comments) you can add my ack.

-- 
Jesse Barnes, Intel Open Source Technology Center