[Intel-gfx] [PATCH] drm/i915: Add sanity check for LVDS timing from VBT

[Zhenyu Wang]

On 2009.07.14 14:21:18 -0700, Jesse Barnes wrote:
> On Fri, 10 Jul 2009 14:51:27 +0800
> Zhenyu Wang <zhenyuw at linux.intel.com> wrote:
> 
> > From: Zhenyu Wang <zhenyu.z.wang at intel.com>
> > 
> > Some invalid LVDS timing block has been observed.
> > It's better to check modeline from VBT instead of
> > possible fail later.
> > 
> > Signed-off-by: Zhenyu Wang <zhenyu.z.wang at intel.com>
> > ---
> 
> This one conflicts with Quanxian's patch. 

oh, I haven't noticed this.

> Also, I'd like to see some
> sanity checks as a drm_crtc_helper function as well (for use before
> calling the actual mode_set routines).  We should be validating the
> hdisp < htotal etc in generic code, and then validate our values are
> divisible by 2 in the LVDS dual channel case for example in the lvds
> mode setting code.

yeah, I'd also like a drm_mode_validate() function, just did a quick
hack to the failure LVDS mode I've seen. 

> 
> This patch is ok though too, assuming this is a fairly common issue, so
> if you can get things worked out with Quanxian (and address Yakui's
> comments) you can add my ack.

In consider this has only been seen on a pre-product machine till now,
I think this is not a common case, but still good to guard it. I'll take
a look at Quanxian's patch, and I think yakui should fix up the drm debug
first. ;)

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090715/1e0781d4/attachment.sig>