[Intel-gfx] [PATCH 2/4] DRM/I915: Add the debug info for i915 connectors/crtc by using DRM_DEBUG_KMS

[Jesse Barnes]

On Mon, 13 Jul 2009 16:07:47 -0700
Eric Anholt <eric at anholt.net> wrote:

> On Thu, 2009-07-09 at 18:02 +0800, yakui.zhao at intel.com wrote:
> > From: Zhao Yakui <yakui.zhao at intel.com>
> > 
> > Add the debug info for i915 connectors/crtc by using the
> > DRM_DEBUG_KMS instead of DRM_DEBUG in KMS mode.
> > 
> > Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> 
> If each file is defining a prefix that happens to be the filename
> slightly mangled, why don't we just use the filename as the prefix and
> not have to specify it per debug call?  We'd get more sensible output
> and less code.
> 
> I still dislike the KMS versus MODE split.  I think I'd end up looking
> up what the difference was supposed to be every time I wrote a debug
> call for them.  (though the fact that they're split by filename makes
> copying easier)

Yeah I'd like to see them unified as well.  I usually want to see both
anyway (core & driver KMS related stuff).

-- 
Jesse Barnes, Intel Open Source Technology Center