[Intel-gfx] [PATCH V2] drm/i915: Choose sharing pipe according to encoder

Jesse Barnes jbarnes at virtuousgeek.org
Mon Jul 27 18:32:41 CEST 2009


On Mon, 27 Jul 2009 17:44:09 +0800
"Ma, Ling" <ling.ma at intel.com> wrote:

> In KMS mode this patch can help us to avoid incorrectly sharing pipe.
> For example it is not allowed to share one pipe between integrated
> TV and VGA according to Bspec.
> Any comments ?

There are a few bits of stray whitespace in the patch, but overall it
looks like a good improvement.  Putting the clone bits in each output
type is better; my only worry there would be if we did load detection
or some other mode programming in one of the init routines before the
sharing constraints had been set.

Assuming those issues are dealt with:

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list