[Intel-gfx] [PATCH V2] drm/i915: Choose sharing pipe according to encoder

[Ma, Ling]

>-----Original Message-----
>From: Jesse Barnes [mailto:jbarnes at virtuousgeek.org]
>Sent: 2009年7月28日 0:33
>To: Ma, Ling
>Cc: eric at anholt.net; intel-gfx at lists.freedesktop.org
>Subject: Re: [Intel-gfx] [PATCH V2] drm/i915: Choose sharing pipe according to
>encoder
>
>On Mon, 27 Jul 2009 17:44:09 +0800
>"Ma, Ling" <ling.ma at intel.com> wrote:
>
>> In KMS mode this patch can help us to avoid incorrectly sharing pipe.
>> For example it is not allowed to share one pipe between integrated
>> TV and VGA according to Bspec.
>> Any comments ?
>
>There are a few bits of stray whitespace in the patch, but overall it
>looks like a good improvement.  Putting the clone bits in each output
>type is better; my only worry there would be if we did load detection
>or some other mode programming in one of the init routines before the
>sharing constraints had been set.
>
>Assuming those issues are dealt with:
Thanks for your review. Current drm will ignore clone case
in drm_pick_crtcs function when system boot.

Thanks
Ma Ling

>Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
>
>--
>Jesse Barnes, Intel Open Source Technology Center