[Intel-gfx] [RFC] [Patch] [DRM/I915] :Add a debufs I/F to dump the I915 register

[Eric Anholt]

On Mon, 2009-06-08 at 08:52 +0800, yakui_zhao wrote:
> On Fri, 2009-06-05 at 19:11 +0800, Eric Anholt wrote:
> > On Fri, 2009-06-05 at 15:45 +0800, yakui_zhao wrote:
> > > It is useful to get the register snapshot. 
> > > Add a debugfs I/F named "i915_reg" to dump the I915 register snapshot. And this
> > > is created under the dri/0/ of debugfs. 
> > > The output format is similar to what we have done in UMS mode.
> > 
> > I don't think that all the decode and formatting of these registers
> > should be in the kernel.  Every time I've had to mess with register
> > decode stuff for investigation, I've needed to extend the decode.
> > Instead, we should expose the raw register values and make
> > intel_reg_dumper in intel-gpu-tools that does the decode of actual
> > meaning.
> Sometimes we can see the register snapshot without using the
> intel-gpu-tools. For example: in UMS mode we often get the register
> snapshot several times in starting X. 
> 
> It will be good that we expose the raw register values and then they are
> parsed by intel-gpu-tools if we need to extend the decode.
> 
> How about adding two debugfs I/F? One is to dump the raw register
> snapshot(without decode and format). Another is what I have done in the
> patch.

No, I won't pull something that puts the decode in the kernel without a
really good argument.  Expose the register names and values.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090609/2f8a3fff/attachment.sig>