[Intel-gfx] [PATCH] drm/i915: Make driver less chatty

Jesse Barnes jbarnes at virtuousgeek.org
Mon Jun 29 18:25:04 CEST 2009


On Sun, 28 Jun 2009 15:42:17 -0700
Keith Packard <keithp at keithp.com> wrote:

> Convert many printk calls to DRM_DEBUG calls to reduce kernel log
> noise for normal activities. Switch other printk calls to DRM_ERROR
> or DRM_INFO.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  drivers/gpu/drm/i915/i915_dma.c     |    2 +-
>  drivers/gpu/drm/i915/i915_drv.c     |    4 ++--
>  drivers/gpu/drm/i915/intel_dp.c     |   11 +++++++----
>  drivers/gpu/drm/i915/intel_dp_i2c.c |   11 ++++++-----
>  drivers/gpu/drm/i915/intel_fb.c     |   18 +++++++++---------
>  drivers/gpu/drm/i915/intel_lvds.c   |    4 ++--
>  6 files changed, 27 insertions(+), 23 deletions(-)

Yay, I'm all for less chattiness.  We also need to go through our
output and classify it according to the new macros Yakui added:
        DRM_DEBUG(fmt, args...)
        DRM_DEBUG_DRIVER(prefix, fmt, args...)
        DRM_DEBUG_KMS(prefix, fmt, args...)
        DRM_DEBUG_MODE(prefix, fmt, args...)
but that should probably be done as a separate patch.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list