[Intel-gfx] [PATCH] drm/i915: Make driver less chatty

[yakui_zhao]

On Tue, 2009-06-30 at 00:25 +0800, Jesse Barnes wrote:
> On Sun, 28 Jun 2009 15:42:17 -0700
> Keith Packard <keithp at keithp.com> wrote:
> 
> > Convert many printk calls to DRM_DEBUG calls to reduce kernel log
> > noise for normal activities. Switch other printk calls to DRM_ERROR
> > or DRM_INFO.
> > 
> > Signed-off-by: Keith Packard <keithp at keithp.com>
> > ---
> >  drivers/gpu/drm/i915/i915_dma.c     |    2 +-
> >  drivers/gpu/drm/i915/i915_drv.c     |    4 ++--
> >  drivers/gpu/drm/i915/intel_dp.c     |   11 +++++++----
> >  drivers/gpu/drm/i915/intel_dp_i2c.c |   11 ++++++-----
> >  drivers/gpu/drm/i915/intel_fb.c     |   18 +++++++++---------
> >  drivers/gpu/drm/i915/intel_lvds.c   |    4 ++--
> >  6 files changed, 27 insertions(+), 23 deletions(-)
> 
> Yay, I'm all for less chattiness.  We also need to go through our
> output and classify it according to the new macros Yakui added:
>         DRM_DEBUG(fmt, args...)
>         DRM_DEBUG_DRIVER(prefix, fmt, args...)
>         DRM_DEBUG_KMS(prefix, fmt, args...)
>         DRM_DEBUG_MODE(prefix, fmt, args...)
> but that should probably be done as a separate patch.
Agree with what Jesse said.
    Will you please use the macro definition mentioned by Jesse so that
we can get the different drm debug info.
    For example:
         The DRM_DEBUG_DRIVER can be used in the file of
i915_dma/i915_drv.c
         The DRM_DEBUG_KMS can be used in the file related with KMS.

thanks.
> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
>