[Intel-gfx] [PATCH] Use zero videoRam and aligned size limit in DRM mode

Eric Anholt eric at anholt.net
Fri May 1 00:27:22 CEST 2009


On Thu, 2009-04-30 at 20:24 +0800, Wu Fengguang wrote:
> On Thu, Apr 30, 2009 at 07:44:21PM +0800, Magnus Kessler wrote:
> > On Thursday 30 Apr 2009 11:44:59 Wu Fengguang wrote:
> > > Explictly set videoRam to 0 in drm mode, to indicate "no size limit".
> > > And to use a large _aligned_ size limit in this case. Because
> > > i830_allocate_aperture() does a testing
> > >
> > >         if (mem->end <= scan->next->offset)
> > >                 break;
> > >
> > > which can fail in a very tricky way when
> > >         mem->end           = rounded up size limit
> > >         scan->next->offset = untouched size limit

Since we don't do any actual allocations out of this allocator for KMS,
could we just not set it up and use some other flag instead of
pI830->memory_manager to indicate whether we're using GEM?

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090430/31e726c3/attachment.sig>


More information about the Intel-gfx mailing list