[Intel-gfx] compiz swapbuffers patch

Barry Scott barry.scott at onelan.co.uk
Mon May 11 13:57:36 CEST 2009


Jesse Barnes wrote:
> On Fri, 08 May 2009 10:27:49 +0100
> Barry Scott <barry.scott at onelan.co.uk> wrote:
>
>   
>> Jesse Barnes wrote:
>>
>> Why are you comparing booleans to TRUE and worse then negating the
>> result?
>>
>> if( !noWait )
>>
>> Is clearer.
>>
>> -			waitForVideoSync (s);
>> +			if (!(noWait == TRUE))
>> +			    waitForVideoSync (s);
>>     
>
> Yeah I've been looking at too much X code.  In some places the style is
> like if (foo == NULL) { ... handle failure ...}.
>   
Personally I always compare to NULL if foo is a pointer as it makes the 
intent
of the code clear.

Barry




More information about the Intel-gfx mailing list