[Intel-gfx] [PATCH V3] drm/i915: sdvo read edid-extensions by i2c bus

[Eric Anholt]

On Wed, 2009-05-13 at 14:22 +0800, Ma Ling wrote:
> Currently drm_get_edid function will fetch basic edid, then determine to continue edid extensions
> by edid->extensions field. However for sdvo output, after first i2c_stop of drm_get_edid function
> we have to do switch ddc bus for following edid extensions, or i2c will fail to work.
> The patch intends to wrap master_xfer function which is responsible to transmit data by i2c,
> switch bus dynamically to get edid extension.

This looks like the right way to go, except:

anholt at gaiman:anholt/src/linux-2.6% ~/src/linux-2.6/scripts/checkpatch.pl ~/\[Intel-gfx\]_\[PATCH_V3\]_drm_i915:_sdvo_read_edid-extensions_by_i2c_bus 
ERROR: code indent should use tabs where possible
#118: FILE: drivers/gpu/drm/i915/intel_sdvo.c:1641:
+^I^I^I          struct i2c_msg msgs[], int num)$

ERROR: trailing whitespace
#120: FILE: drivers/gpu/drm/i915/intel_sdvo.c:1643:
+^Istruct intel_output *intel_output; $

WARNING: line over 80 characters
#127: FILE: drivers/gpu/drm/i915/intel_sdvo.c:1650:
+		intel_sdvo_chan_to_intel_output((struct intel_i2c_chan *)(algo_data->data));

ERROR: trailing whitespace
#130: FILE: drivers/gpu/drm/i915/intel_sdvo.c:1653:
+^I$

ERROR: trailing whitespace
#160: FILE: drivers/gpu/drm/i915/intel_sdvo.c:1838:
+^I^I^I$

ERROR: trailing whitespace
#163: FILE: drivers/gpu/drm/i915/intel_sdvo.c:1841:
+^I$

WARNING: line over 80 characters
#167: FILE: drivers/gpu/drm/i915/intel_sdvo.c:1845:
+	intel_sdvo_i2c_bit_algo.functionality = intel_output->i2c_bus->adapter.algo->functionality;

ERROR: Missing Signed-off-by: line(s)

total: 6 errors, 2 warnings, 94 lines checked

/home/anholt/[Intel-gfx]_[PATCH_V3]_drm_i915:_sdvo_read_edid-extensions_by_i2c_bus has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS

Also, there's no reason to manually cast void * pointers to their target
type -- it just clutters up the code and pushes you past 80 columns as
you can see in the first warning.

The missing signed-off-by error looks spurious at first glance, but
actually looks like it isn't -- there's a problem I've been having with
mails coming from the Shanghai team where unicode U+FEFF (non-breaking
space) characters are sprinkled around the commit messages, which messes
up formatting of the commit logs and confuses tools like this one. 

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090514/68a24c68/attachment.sig>