[Intel-gfx] [PATCH 2/6] drm/i915: Add EXPORT_SYMBOL()s needed for sharing VDC code

[Richard Purdie]

On Thu, 2009-05-14 at 13:35 -0700, Jesse Barnes wrote:
> On Wed, 13 May 2009 15:02:58 +0100
> Richard Purdie <rpurdie at linux.intel.com> wrote:
> > Index: git/drivers/gpu/drm/i915/i915_suspend.c
> > ===================================================================
> > --- git.orig/drivers/gpu/drm/i915/i915_suspend.c	2009-05-13
> > 10:51:08.000000000 +0100 +++
> > git/drivers/gpu/drm/i915/i915_suspend.c	2009-05-13
> > 12:19:48.000000000 +0100 @@ -368,6 +368,7 @@ 
> >  	return 0;
> >  }
> > +EXPORT_SYMBOL(i915_save_state);
> >  
> >  int i915_restore_state(struct drm_device *dev)
> >  {
> > @@ -538,4 +539,5 @@
> >  
> >  	return 0;
> >  }
> > +EXPORT_SYMBOL(i915_restore_state);
> 
> These are the only ones that don't really fit.  I think we'll want to
> create separate VDC save/restore functions and make the i915 code call
> that (in addition to doing other, i915-specific stuff like save/restore
> of fences).

These functions actually work as they are Poulsbo. I'm not arguing
against making some which are more VDC specific and there are certainly
parts with are probably unneeded but its not as different as you'd at
first think. Poulsbo has the same fence registers as the 915 for example
(but MRST doesn't).

This is probably something we can visit in a subsequent patch (along
with dealing with the suspend registers better)?

-- 
Richard Purdie
Intel Open Source Technology Centre