[Intel-gfx] [PATCH]drm_i915: remove unnecessary object pin for mode set

[Florian Mickler]

On Fri, 15 May 2009 08:25:11 -0700
Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> Yes the 2D driver is confused here, but I'm pretty sure we want to
> keep the pin in pipe_set_base.  With KMS we shouldn't have to do
> userspace pinning at all.  I think this is really a 2D teardown
> problem, not a kernel problem.
> 

i can provoke that warning doing: 
xrandr --output LVDS1 --off 

if I xrandr --output LVDS1 --auto afterwards, the following comes in dmesg:
May 15 08:05:40 schatten [ 2011.206435] [drm:drm_crtc_helper_set_config] *ERROR* failed to set mode on crtc ffff88007e176000 


i have tested the patch and the warning disappears on xrandr --off, but it then bugs (and the the framebuffer freezes) on some sequence of doing:

xrandr --output LVDS1 --auto 
and 
xrandr --output LVDS1 --off 

like this:

May 15 16:43:18 schatten [   86.452225] [drm:drm_crtc_helper_set_config] *ERROR* failed to set mode on crtc ffff88007dfe7000
May 15 16:43:33 schatten [  101.875848] ------------[ cut here ]------------
May 15 16:43:33 schatten [  101.875853] kernel BUG at drivers/gpu/drm/i915/i915_gem.c:3525!
May 15 16:43:33 schatten [  101.875856] invalid opcode: 0000 [#1] SMP 
May 15 16:43:33 schatten [  101.875859] last sysfs file: /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq
May 15 16:43:33 schatten [  101.875861] CPU 1 
May 15 16:43:33 schatten [  101.875863] Modules linked in:
May 15 16:43:33 schatten [  101.875867] Pid: 4624, comm: X Not tainted 2.6.30-rc5-00001-g66ff601 #30 8943DNG
May 15 16:43:33 schatten [  101.875869] RIP: 0010:[<ffffffff8056faf6>]  [<ffffffff8056faf6>] i915_gem_object_unpin+0x86/0xa0
May 15 16:43:33 schatten [  101.875877] RSP: 0018:ffff88007c5cbd58  EFLAGS: 00010286
May 15 16:43:33 schatten [  101.875879] RAX: 00000000ffffffff RBX: ffff8800799ce200 RCX: ffff8800799ce200
May 15 16:43:33 schatten [  101.875882] RDX: ffff8800799ce140 RSI: ffff8800799ce140 RDI: ffff8800799ce200
May 15 16:43:33 schatten [  101.875884] RBP: ffff88007c5cbd58 R08: ffff88007e058800 R09: ffff88007e05e000
May 15 16:43:33 schatten [  101.875886] R10: 0000000000000000 R11: 0000000000003246 R12: ffff88007c5cbdc8
May 15 16:43:33 schatten [  101.875888] R13: ffff88007b473e00 R14: ffff88007e058820 R15: 0000000040086456
May 15 16:43:33 schatten [  101.875891] FS:  00007f329eea96f0(0000) GS:ffff880001029000(0000) knlGS:0000000000000000
May 15 16:43:33 schatten [  101.875893] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
May 15 16:43:33 schatten [  101.875895] CR2: 00007f5fe67f9820 CR3: 0000000079837000 CR4: 00000000000006e0
May 15 16:43:33 schatten [  101.875897] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
May 15 16:43:33 schatten [  101.875900] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
May 15 16:43:33 schatten [  101.875902] Process X (pid: 4624, threadinfo ffff88007c5ca000, task ffff88007f3d3980)
May 15 16:43:33 schatten [  101.875904] Stack:
May 15 16:43:33 schatten [  101.875905]  ffff88007c5cbd88 ffffffff80570a43 ffff88007e058800 ffffffff80b879e0
May 15 16:43:33 schatten [  101.875908]  ffff88007c5cbdc8 ffff88007b473e00 ffff88007c5cbe78 ffffffff8055789e
May 15 16:43:33 schatten [  101.875912]  ffff88007c5cbda8 ffffffff8024d397 ffff88007c5cbde8 00007fff65b0a820
May 15 16:43:33 schatten [  101.875916] Call Trace:
May 15 16:43:33 schatten [  101.875918]  [<ffffffff80570a43>] i915_gem_unpin_ioctl+0xb3/0x120
May 15 16:43:33 schatten [  101.875922]  [<ffffffff8055789e>] drm_ioctl+0x16e/0x380
May 15 16:43:33 schatten [  101.875926]  [<ffffffff8024d397>] ? recalc_sigpending+0x17/0x50
May 15 16:43:33 schatten [  101.875931]  [<ffffffff80570990>] ? i915_gem_unpin_ioctl+0x0/0x120
May 15 16:43:33 schatten [  101.875934]  [<ffffffff80213c53>] ? save_i387_xstate+0x1b3/0x1f0
May 15 16:43:33 schatten [  101.875938]  [<ffffffff8024d397>] ? recalc_sigpending+0x17/0x50
May 15 16:43:33 schatten [  101.875941]  [<ffffffff8020aaff>] ? do_notify_resume+0x1df/0x7e0
May 15 16:43:33 schatten [  101.875945]  [<ffffffff802dfd55>] vfs_ioctl+0x85/0xa0
May 15 16:43:33 schatten [  101.875949]  [<ffffffff802dff7b>] do_vfs_ioctl+0x20b/0x510
May 15 16:43:33 schatten [  101.875952]  [<ffffffff80213daa>] ? restore_i387_xstate+0x11a/0x180
May 15 16:43:33 schatten [  101.875955]  [<ffffffff804773a6>] ? security_file_permission+0x16/0x20
May 15 16:43:33 schatten [  101.875959]  [<ffffffff802e0307>] sys_ioctl+0x87/0xa0
May 15 16:43:33 schatten [  101.875962]  [<ffffffff8020b45b>] system_call_fastpath+0x16/0x1b
May 15 16:43:33 schatten [  101.875966] Code: 48 8b 4e 10 48 8b 42 08 48 89 41 08 48 89 08 49 8d 81 c8 0c 00 00 48 8b 48 08 48 89 46 10 48 89 50 08 48 89 11 48 89 4a 08 eb b3 <0f> 0b eb fe 66 0f 1f 44 00 00 0f 0b eb fe 66 66 66 2e 0f 1f 84 
May 15 16:43:33 schatten [  101.875994] RIP  [<ffffffff8056faf6>] i915_gem_object_unpin+0x86/0xa0
May 15 16:43:33 schatten [  101.875998]  RSP <ffff88007c5cbd58>
May 15 16:43:33 schatten [  101.876000] ---[ end trace
ce4148ac84e3c610 ]---


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090517/8250b522/attachment.sig>