[Intel-gfx] [PATCH] drm/i915: Determine type before initialising connector

[Jesse Barnes]

On Fri, 22 May 2009 12:42:34 -0700
Eric Anholt <eric at anholt.net> wrote:

> On Fri, 2009-05-15 at 09:10 +0200, Jonas Bonn wrote:
> > drm_connector_init sets both the connector type and the connector
> > type_id on the newly initialised connector.  As the connector
> > type_id is coupled to the connector type, the connector type cannot
> > simply be modified on an initialised connector.
> > 
> > This patch changes the order of operations on intel_sdvo_init so
> > that the type is determined before the connector is intialised.
> > 
> > This fixes a bug whereby the name card0-VGA-1 would be allocted to
> > both a CRT and an SDVO connector since the SDVO connector would be
> > initialised with type 'unknown' and hence have its type_id assigned
> > from the wrong pool.
> > 
> > Signed-off-by: Jonas Bonn <jonas at southpole.se>
> 
> I like the look of this.  jbarnes, you agree?

Yeah, looks good to me.  Ma Ling's comments are still valid, but this
patch is still an improvement.

Jesse