[Intel-gfx] [Patch 0/3] DRM/I915: Use the child device array to decide whether the given HDMI/DP should be initialzied

[Eric Anholt]

On Fri, 2009-09-18 at 08:53 +0800, ykzhao wrote:
> On Fri, 2009-09-18 at 03:20 +0800, Adam Jackson wrote:
> > I wasn't subscribed at the time (else I'd follow up to the right
> > message), but I was recently pointed to this patch series:
> > 
> > http://lists.freedesktop.org/archives/intel-gfx/2009-July/003634.html
> > 
> > It seems like it should do the right thing according to my manual dump
> > of the VBT on some laptops I've got handy, though I've not tried it yet.
> > Some comments though:
> Thanks for your comments.
> > 
> > - HDMI_CLASS/INT_DP_CLASS and the associated PORT and DVO defines should
> > really live in intel_bios.h next to the other device types.
> Agree. They had better be defined in intel_bios.h together. 
> > 
> > - TV seems to be device type 1009, and LFP to be 1022, but those aren't
> > in intel_bios.h.  Would be nice to resync that with the BIOS sources.
> It is also ok to add their definition.(TV_TYPE, LFP_TYPE). But now the
> child device array is not used to initialize the TV/LVDS. So it is
> unnecessary to add their definitions.

Those are exactly the two types of outputs that most need to use the
table to detect them, though!

I'd like to see this patch series redone with the definitions in
intel_bios.h where they should be and TV and LVDS support, for 2.6.33.


-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091013/9e4f8ff3/attachment.sig>