[Intel-gfx] [RFC, PATCH] drm/i915: split display functions by chip type

Keith Packard keithp at keithp.com
Tue Sep 15 00:29:46 CEST 2009


On Mon, 2009-09-14 at 14:51 -0700, Jesse Barnes wrote:
> This patch is a long time coming IMO, and there are many more cleanups
> possible.  It splits out several of the display functions into a
> separate display function table to avoid tons of chipset specific
> if..else if..else if blocks all over.
> 
> Zhenyu, what do you think?  Should help with adding new hardware
> support over time and make functionality a bit clearer.

I worry that we'll end up with piles of nearly-duplicated code and
forget to replicate bug fixes across all chips.

Any idea how to balance this?

-keith

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090914/ddae5df8/attachment.sig>


More information about the Intel-gfx mailing list