[Intel-gfx] [PATCH 2/2] drm/i915: disable powersave feature for Ironlake currently

[Jesse Barnes]

On Tue, 29 Sep 2009 11:01:23 +0800
Zhenyu Wang <zhenyuw at linux.intel.com> wrote:

> On 2009.09.28 10:38:14 -0700, Jesse Barnes wrote:
> > On Fri, 25 Sep 2009 16:01:29 +0800
> > Zhenyu Wang <zhenyuw at linux.intel.com> wrote:
> > 
> > > Until we figure out the right setting for powersave features on
> > > Ironlake, disable it for now, also disable watermark update,
> > > which has new registers for it on Ironlake too.
> > > 
> > > Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/i915_dma.c      |    3 +++
> > >  drivers/gpu/drm/i915/intel_display.c |    3 +++
> > >  2 files changed, 6 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_dma.c
> > > b/drivers/gpu/drm/i915/i915_dma.c index 45d507e..733f051 100644
> > > --- a/drivers/gpu/drm/i915/i915_dma.c
> > > +++ b/drivers/gpu/drm/i915/i915_dma.c
> > > @@ -1202,6 +1202,9 @@ static int i915_load_modeset_init(struct
> > > drm_device *dev, if (IS_I965G(dev) || IS_G33(dev))
> > >  		dev_priv->cursor_needs_physical = false;
> > >  
> > > +	if (IS_IGDNG(dev))
> > > +		i915_powersave = 0;
> > 
> > Can you use the new function pointer code instead?  Just make no-ops
> > for the watermark update functions and the other stuff that doesn't
> > work...
> > 
> 
> yeah, that'll be better. How about this one?
> 
> From 26f1a7aad7c990b3d6c600bd03eb41fbc2274d68 Mon Sep 17 00:00:00 2001
> From: Zhenyu Wang <zhenyuw at linux.intel.com>
> Date: Tue, 29 Sep 2009 03:54:53 +0800
> Subject: [PATCH] drm/i915: disable powersave feature for Ironlake
> currently
> 
> Until we figure out the right setting for powersave features on
> Ironlake, disable it for now. Also disable watermark update,
> which has new registers for it on Ironlake too.
> 
> Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>

Yeah, that looks better.  Thanks.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Jesse