[Intel-gfx] [PATCH] drm/i915: intel_overlay_print_error_state() only needed for debugfs (v2)

Chris Wilson chris at chris-wilson.co.uk
Thu Aug 26 12:02:39 CEST 2010


On Thu, 26 Aug 2010 01:52:16 +0200, Tobias Doerffel <tobias.doerffel at gmail.com> wrote:
> The function intel_overlay_print_error_state() is called from within
> i915_error_state() in i915_debufs.c which is only built if
> CONFIG_DEBUG_FS is set. When building without this option, seq_printf()
> is not declared in intel_overlay.c and the file fails to compile.
> Furthermore the whole function is superfluous in this case. Therefore
> only build it if CONFIG_DEBUG_FS is set.
> 
> Signed-off-by: Tobias Doerffel <tobias.doerffel at gmail.com>
I've already posted a better patch to remove the compile warnings as well.

The simple inclusion of seq_file.h is the best patch to go into mainline
atm, with the more complete patch coming in via drm-intel-next.

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list