[Intel-gfx] [PATCH] drm/i915: Ignore lid status on 915-945 too.

[Jesse Barnes]

On Wed, 17 Mar 2010 13:50:06 -0700
Eric Anholt <eric at anholt.net> wrote:

> I've been getting more quirk reports for this generation.  Better to
> light up an unintended panel than to not light up the only usable
> output on the system.
> 
> Signed-off-by: Eric Anholt <eric at anholt.net>
> ---
> 
> I'm not sure whether the patch I want is this one or just removing
> this lid status usage entirely.  It's been a massive failure so far.
> 
>  drivers/gpu/drm/i915/intel_lvds.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 14e516f..a1c8f02 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -669,7 +669,7 @@ static enum drm_connector_status intel_lvds_detect(struct drm_connector *connect
>  	/* ACPI lid methods were generally unreliable in this generation, so
>  	 * don't even bother.
>  	 */
> -	if (IS_GEN2(dev))
> +	if (IS_GEN2(dev) || IS_GEN3(dev))
>  		return connector_status_connected;
>  
>  	if (!dmi_check_system(bad_lid_status) && !acpi_lid_open())

Removing it entirely would be fine with me.  It seems other OSes only
use lid notification at their core, so status often lies (I suspect
some OEM specific tools rely on it, but since we don't have an accurate
list we can't rely on it generally).

-- 
Jesse Barnes, Intel Open Source Technology Center