[Intel-gfx] [intel-gfx][PATCH 2/2] drm/i915: Add a new ring buffer on Sandybridge

[Zhenyu Wang]

On 2010.09.02 16:56:19 +0200, Daniel Vetter wrote:
> If I'm not completely mistaken, all these ringbuffer register have the
> same offsets over a common base: 0x02000 for the render ring, 0x04000 for
> bsd on gen5, 0x12000 for bsd on gen6.

yes, 0x22000 for blitter on gen6.

> 
> Can't we just store that base somewhere in intel_ring_buffer and kill all
> these copy&pasted register access macros? I've played around a bit with
> this, and most functions become so small it's cheaper to convert them to
> inlines. This also has the potential make the other functions simpler,
> perhaps even making them fully generic. Oh, and adding new ringbuffers
> should becoma way easier, too (blitter ring anyone?).
> 
> At least my local hacks here where good enough to watch the lotr. If you
> want I'll push them somewhere, but the patches are not really great and
> definitely conflict against newer stuff.
> 

please put it somewhere, I'd like to take a look, I feel uncomfortable to add
blitter ring in current structure...

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100902/158657b1/attachment.sig>