[Intel-gfx] [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in struct intel_ring_buffer

Zhenyu Wang zhenyuw at linux.intel.com
Thu Sep 16 07:37:49 CEST 2010


On 2010.09.16 13:10:29 +0800, Xiang, Haihao wrote:
> > Or can't that be done in init function by using advance_ring?
> advance_ring uses ring->tail to set TAIL register, i965_reset() also
> invokes ring->init() to re-init ring buffer, how to guarantee ring->tail
> is 0? BTW advance_ring can be implemented as set_tail(dev, ring->tail).
> 

oh, that's bad, not only just for render ring, but ring tail should
always be inited correctly, not just in static variable..

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100916/8e12b57c/attachment.sig>


More information about the Intel-gfx mailing list