[Intel-gfx] [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in struct intel_ring_buffer

[Xiang, Haihao]

On Thu, 2010-09-16 at 13:37 +0800, Zhenyu Wang wrote:
> On 2010.09.16 13:10:29 +0800, Xiang, Haihao wrote:
> > > Or can't that be done in init function by using advance_ring?
> > advance_ring uses ring->tail to set TAIL register, i965_reset() also
> > invokes ring->init() to re-init ring buffer, how to guarantee ring->tail
> > is 0? BTW advance_ring can be implemented as set_tail(dev, ring->tail).
> > 
> 
> oh, that's bad, not only just for render ring, but ring tail should
> always be inited correctly, not just in static variable..
> 
init_ring_common() always inits ring tail. so it is not just in static
variable.