[Intel-gfx] [PATCH 1/7] drm/i915: automatic FDI training support for Ivy Bridge

Jesse Barnes jbarnes at virtuousgeek.org
Wed Apr 27 22:52:23 CEST 2011


On 4/26/2011 11:19 PM, Chris Wilson wrote:
>  On Tue, 26 Apr 2011 17:06:01 -0700, Jesse Barnes
>  <jbarnes at virtuousgeek.org> wrote:
> > You can ignore this set; I only sent it because I thought the
> > others wouldn't come through.
>
>  Before I find the others... Do they treat IS_IVYBRIDGE() vs IS_GEN7
>  consistently? Do they have sufficient debug and self-tests?

I think so, another audit wouldn't hurt though (generally I used IS_IVB 
for display related checks ans IS_GEN7 for render related differences).

>  Can we split intel_enable_clock_gating() up into several "little"
>  functions that address the peculiarity of each generation
>  individually? -Chris

Yes, that's probably a good idea.

Jesse






More information about the Intel-gfx mailing list