[Intel-gfx] [PATCH 2/3] drm/i915: Rename HDMI register field definitions
Chris Wilson
chris at chris-wilson.co.uk
Fri Oct 14 23:39:08 CEST 2011
On Fri, 14 Oct 2011 18:17:09 -0300, przanoni at gmail.com wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> Also making the differences between HDMI{B,C,D} and SDVO registers for
> non-PCH, IBX and CPT more explicit.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
I'm a little more dubious over the value of this patch. The extra
information is nice, but the patch doesn't impact much upon the
readibility of the code. It seems like this should have the potential to
clarify quite a bit of the logic and make it more consistent, yet that
is not addressed here. Do you have plans to make use of the cleanup?
Does it catch any bugs?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx
mailing list