[Intel-gfx] [PATCH] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI

[Keith Packard]

On Tue, 20 Sep 2011 17:38:37 +0100, Simon Farnsworth <simon.farnsworth at onelan.co.uk> wrote:

> This interacts badly with the need I've found to call this function every time 
> a hotplug interrupt comes through (explained below) - I'm not sure how to 
> track back from the encoder (which gets the callback) to the SDVO device 
> number.

You might store the desired hotplug bits in the intel_sdvo structure,
and then use that in the enable function. The enable function should be
able to just call SET_ACTIVE_HOT_PLUG with the desired value instead of
making the four calls that it does now, right?

> If I don't call intel_sdvo_enable_hotplug at this point, I only get the one 
> hotplug interrupt; it appears that the SDVO devices I have send their 
> interrupt, then expect you to re-enable HPD interrupts before they will send 
> another interrupt.

ok, sounds good.

> I'm not sure how best to handle this; my gut feeling is that there's no real 
> harm enabling HPD interrupts on all ports that support it, even though I'm 
> only processing HPD interrupts from DVI and HDMI ports. If you have better 
> ideas, I'm happy to try them.

It probably is harmless, just seems a bit messy.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110920/9141cd96/attachment.sig>