[Intel-gfx] [PATCH] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI

[Simon Farnsworth]

On Tuesday 20 September 2011, Keith Packard <keithp at keithp.com> wrote:
> On Tue, 20 Sep 2011 17:38:37 +0100, Simon Farnsworth 
<simon.farnsworth at onelan.co.uk> wrote:
> > This interacts badly with the need I've found to call this function every
> > time a hotplug interrupt comes through (explained below) - I'm not sure
> > how to track back from the encoder (which gets the callback) to the SDVO
> > device number.
> 
> You might store the desired hotplug bits in the intel_sdvo structure,
> and then use that in the enable function. The enable function should be
> able to just call SET_ACTIVE_HOT_PLUG with the desired value instead of
> making the four calls that it does now, right?
> 
Sounds perfectly reasonable to me. I'll whip up patch v5 before I head home 
tonight.

> > If I don't call intel_sdvo_enable_hotplug at this point, I only get the
> > one hotplug interrupt; it appears that the SDVO devices I have send
> > their interrupt, then expect you to re-enable HPD interrupts before they
> > will send another interrupt.
> 
> ok, sounds good.
> 
I'll add a comment to the code so that future reviewers understand why I'm 
doing it.
-- 
Simon Farnsworth
Software Engineer
ONELAN Limited
http://www.onelan.com/