[Intel-gfx] [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI

[Keith Packard]

On Tue, 20 Sep 2011 18:31:25 +0100, Simon Farnsworth <simon.farnsworth at onelan.co.uk> wrote:

> +	/* Set up hotplug command - note paranoia about contents of reply.
> +	 * We simply clear out the bits we understand, and hope that
> +	 * the rest are in good shape for the hardware.
> +	 */
> +	intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT,
> +			     &intel_sdvo->hotplug_active, 2);
> +	intel_sdvo->hotplug_active[0] &= 0x3;
> +

This appears to unconditionally set the bits for devices 0 and 1, making
the dvi-specific code that sets the device bit irrelevant. I think you
just want to set hotplug_active to 0.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110920/c82e2973/attachment.sig>