[Intel-gfx] [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI

[Simon Farnsworth]

On Tuesday 20 September 2011, Keith Packard <keithp at keithp.com> wrote:
> On Tue, 20 Sep 2011 18:31:25 +0100, Simon Farnsworth 
<simon.farnsworth at onelan.co.uk> wrote:
> > +	/* Set up hotplug command - note paranoia about contents of reply.
> > +	 * We simply clear out the bits we understand, and hope that
> > +	 * the rest are in good shape for the hardware.
> > +	 */
> > +	intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT,
> > +			     &intel_sdvo->hotplug_active, 2);
> > +	intel_sdvo->hotplug_active[0] &= 0x3;
> > +
> 
> This appears to unconditionally set the bits for devices 0 and 1, making
> the dvi-specific code that sets the device bit irrelevant. I think you
> just want to set hotplug_active to 0.

I'm clearing the bits (&= not |=). I could respin setting it to 0, but that 
takes me even further from the old (commented out) code, and I'd really want 
someone to check SDVO specs before doing that.
-- 
Simon Farnsworth
Software Engineer
ONELAN Limited
http://www.onelan.com/