[Intel-gfx] [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI

[Keith Packard]

On Wed, 21 Sep 2011 10:08:13 +0100, Simon Farnsworth <simon.farnsworth at onelan.co.uk> wrote:

> I'm clearing the bits (&= not |=). I could respin setting it to 0, but that 
> takes me even further from the old (commented out) code, and I'd really want 
> someone to check SDVO specs before doing that.

What I see the code doing is asking whether devices 0 and 1 *could*
support hotplug and then unconditionally setting the devices for which
we *want* hotplug to that.

I think you should set the list of devices requesting hotplug to be the
intersection of the set of devices which *could* do hotplug and the
set of devices for which we *want* hotplug.

That seems like it would be achieved by just clearing the set of devices
that we will request hotplug for and then checking which ones are
supported and incrementally adding those to the hotplug_active set.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110921/40bd3517/attachment.sig>