[Intel-gfx] [PATCH 1/1] drm/i915: split power-related items into intel_pm module

Eugeni Dodonov eugeni at dodonov.net
Tue Apr 17 02:08:22 CEST 2012

On Mon, Apr 16, 2012 at 20:23, Chris Wilson <chris at chris-wilson.co.uk>wrote:

> On Mon, 16 Apr 2012 20:06:01 -0300, Eugeni Dodonov <
> eugeni.dodonov at intel.com> wrote:
> > As previously discussed on irc with Daniel, Ben and Jesse, This patch
> > moves the power-related functionality into intel_pm module, aiming at
> > simplifying the intel_display code and make it less cluttered.
> >
> > The functionality affected by this move are: clock gating, rc6 and rps,
> > display watermarks, display fifo-related items, cxsr and FBC.
> >
> > This simplifies intel_display by +/- 2800 lines of code and centralizes
> > most of the power-related items in one place to simplify future hardware
> > enablement and subsystems interaction.
> Diff is making this really difficult to verify that no functional change
> is taking place. Suggestions? A series of small commits?

I am fine with making it into a small series of commits which move 1
subsystem at a time (fbc, cxsr, rc6, fifo, wm, ...). Would everyone be
happy with that? I think Daniel wanted to move everything in 1 commit,
hence this initial approach from my side, but yes, as functions are spread
all around the place it makes very hard to review the patch.

But in general, does this idea of intel_pm.c looks interesting, or anyone
has anything against it?

Eugeni Dodonov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120416/2c760a6f/attachment.html>

More information about the Intel-gfx mailing list