[Intel-gfx] [PATCH] drm/i915: don't unconditionally enable SPRITE_DEST_KEY on IVB

[Daniel Vetter]

On Tue, Feb 07, 2012 at 01:38:38PM -0800, Jesse Barnes wrote:
> Now that we have specific color key ioctls, we don't need to set this
> all the time.
> 
> Reported-by: Armin C Reese <armin.c.reese at intel.com>
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/intel_sprite.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 2288abf..4636811 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -95,7 +95,6 @@ ivb_update_plane(struct drm_plane *plane, struct drm_framebuffer *fb,
>  	/* must disable */
>  	sprctl |= SPRITE_TRICKLE_FEED_DISABLE;
>  	sprctl |= SPRITE_ENABLE;
> -	sprctl |= SPRITE_DEST_KEY;

Meh, that sucker slipped my review of the original colour key patches
where it's been added.

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48