[Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

Kai Krakow hurikhan77 at gmail.com
Sat Feb 11 19:13:52 CET 2012


Chris Wilson <chris at chris-wilson.co.uk> schrieb:

>> +     if (rc6_mode > 0) {
> I'm a little uneasy mixing signs and bitmasks, and this test looks a
> little pointless as intel_enable_rc6 now returns the bitmask. Kill it
> and we kill one level of indentation!

I think not, because Eugeni documented "-1" as the chipset default...

Just my 2 cents...

Regards,
Kai




More information about the Intel-gfx mailing list