[Intel-gfx] [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter

[Eugeni Dodonov]

On Sat, Feb 11, 2012 at 16:13, Kai Krakow <hurikhan77 at gmail.com> wrote:

> Chris Wilson <chris at chris-wilson.co.uk> schrieb:
>
> >> +     if (rc6_mode > 0) {
> > I'm a little uneasy mixing signs and bitmasks, and this test looks a
> > little pointless as intel_enable_rc6 now returns the bitmask. Kill it
> > and we kill one level of indentation!
>
> I think not, because Eugeni documented "-1" as the chipset default...
>

Not quite, Chris is right, we can get rid of this if block. Chipset default
values are being handled by the intel_enable_rc6(), that function returns a
valid bitmask now. So it will always return some meaningful values to us
and explicitly say if RC6 should be disabled or enabled (and if enabled,
which states are active).

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120211/a9c1d621/attachment.html>