[Intel-gfx] [PATCH 05/14] drm/i915: kill ranged cpu read domain support
eric at anholt.net
Thu Feb 16 17:48:07 CET 2012
On Thu, 16 Feb 2012 13:11:31 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> No longer needed.
What this code was for: Before gtt mapping, we were doing software
fallbacks in Mesa with pread/write on pages at a time (or worse) of the
framebuffer. It would regularly result in hitting the same page again,
since I was only caching the last page I'd pulled out, instead of
keeping a whole copy of the framebuffer during the fallback.
Since we've been doing gtt mapping for years at this point, I'm happy to
see the code die.
I'm not sure about the rest of the code. In particular, for the code
that's switching between gtt and cpu mappings to handle a read/write,
I'm concerned about whether the behavior matches for tiled objects. I
haven't reviewed enough to be sure.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the Intel-gfx