[Intel-gfx] [PATCH] drm/i915/dp: Add branch/sink OUI debugging

[Julien Cristau]

On Fri, Jan 13, 2012 at 13:26:08 -0500, Adam Jackson wrote:

> DisplayPort lets you discover the manufacturer OUI of the other end.
> This is good, because it means you might be able to have per-phy quirks
> to work around other people's bugs, but it's bad because it removes some
> incentive to not make buggy hardware.
> 
> At any rate DisplayPort is proving fickle enough that I'm getting
> desperate.  Dump the OUI in the log when KMS debug is on.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c |   33 +++++++++++++++++++++++++++++++++
>  include/drm/drm_dp_helper.h     |    8 ++++++++
>  2 files changed, 41 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index db3b461..96b3fe2 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2097,6 +2097,37 @@ intel_dp_get_edid_modes(struct drm_connector *connector, struct i2c_adapter *ada
>  	return ret;
>  }
>  
> +static void
> +intel_dp_debug_oui(struct intel_dp *dp, uint8_t dpcd[DP_RECEIVER_CAP_SIZE])
> +{
> +	uint8_t count;
> +	int offset;
> +	uint8_t oui[3];
> +
> +	/* not valid in 1.0 */
> +	if (dpcd[0] == < 0x11)
                    ^^^^
That looks broken.

Cheers,
Julien