[Intel-gfx] [PATCH 0/4] [CFT] interlaced support

Paulo Zanoni przanoni at gmail.com
Fri Jan 27 17:25:49 CET 2012


Ok, so I had to look at the Windows registers again...

Your "interlaced" branch had 6 patches. Patch 3 is the only one I
changed. Here is my version:
http://people.freedesktop.org/~pzanoni/0003-drm-i915-fixup-interlace-vertical-timings-confusion.patch.
Now my monitor reports "1080i" :)

Some notes about the patch:

- I really like your solution of not using CRTC_INTERLACE_HALVE_V,
because previously we were dividing by 2 and then multiplying by 2
again, which would not restore the original values in case of odd
numbers.

- I'm not sure about the change inside drm_modes.c. Why do we need the
"|= 1"? I fear it could cause us some troubles. This change might also
break the other drivers, of course. Wel'll need a "v4".

- It seems we need vtotal-- and vblank_end--. We need to find evidence
for that in the documentation. I'm just copying Windows

- I tested only on SNB. This time the screen looks good (previous
versions were really ugly). I'll test ilk and report if something goes
wrong...

Cheers,
Paulo

-- 
Paulo Zanoni



More information about the Intel-gfx mailing list