[Intel-gfx] [PATCH] drm/i915: Add comments to explain the BSD tail write workaround

Daniel Vetter daniel at ffwll.ch
Wed Jul 11 00:47:07 CEST 2012


On Thu, Jul 05, 2012 at 05:14:01PM +0100, Chris Wilson wrote:
> Having had to dive into the bspec to understand what each stage of the
> workaround meant, and how that the ring broadcasting IDLE corresponded
> with the GT powering down the ring (i.e. rc6) add comments to aide
> the next reader.
> 
> And since the register "is used to control all aspects of PSMI and power
> saving functions" that makes it quite interesting to inspect with
> regards to RC6 hangs, so add it to the error-state.
> 
> v2: Rediscover the piece of magic, set the RNCID to 0 before waiting for
> the ring to wake up.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list