[Intel-gfx] [PATCH] Revert "drm/i915/dp: Use auxch precharge value of 5 everywhere"

Daniel Vetter daniel at ffwll.ch
Fri Jun 15 10:50:44 CEST 2012


On Thu, Jun 14, 2012 at 10:15:00PM +0200, Daniel Vetter wrote:
> This reverts commit 092945e11c5b84f66dd08f0b87fb729715d377bc.
> 
> This commit prevents a DP screen from properly training the link.
> Oddly enough it works, once the machine has been warm-booted with an
> older kernel.
> 
> According to DP docs this _should_ have been the right precharge time.
> Also, the commit that originally introduces this was just general snb
> DP enabling and didn't mention any specific reason for this special
> value. Whatever, trust the reporter that this makes things worse and
> let's just revert it.
> 
> v2: Less spelling fail.
> 
> Cc: Adam Jackson <ajax at redhat.com>
> Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> Reported-by: "Wouter M. Koolen" <W.M.Koolen-Wijkstra at cwi.nl>
> Buglink: https://lkml.org/lkml/2012/6/14/301
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
No one yelled around with a better idea, so I've picked this up for fixes
with cc stable.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list