[Intel-gfx] [PATCH] drm/i915: Retry reading the PCH FDI receiver ISR

Daniel Vetter daniel at ffwll.ch
Fri Mar 2 19:40:04 CET 2012


On Fri, Mar 02, 2012 at 10:03:58AM -0800, Jesse Barnes wrote:
> On Fri,  2 Mar 2012 12:53:39 -0500
> Sean Paul <seanpaul at chromium.org> wrote:
> 
> > According to the PRM (Vol3P2), the PCH FDI receiver ISR read for bit lock
> > should be retried at least once. This patch retries the read 5 times
> > with a small delay in between reads. I've had reports of display corruption
> > on resume with "FDI train 1 fail!", so I'm hoping that adding this retry
> > will mitigate the issue.
> > 
> > Signed-off-by: Sean Paul <seanpaul at chromium.org>
> > ---
> 
> Yeah seems fine.  I think we don't quite match the training sequence in
> the docs for other generations either, but failures haven't been common
> so dealing with things case by case like this is fine.
> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list